[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin dump/load proposal

From: Max Bowsher <maxb_at_ukf.net>
Date: 2004-09-09 23:44:27 CEST

kfogel@collab.net wrote:
> Mark Phippard <MarkP@softlanding.com> writes:
>> My company is working on porting Subversion to OS/400, an EBCDIC system.
>> As a side note, things are actually going pretty well with this port
>> although it has been a lot of work.
>> We are currently running into a problem with svnadmin dump and load
>> because of the way OS/400 handles pipes and redirections, specifically it
>> wants to convert the stream to/from EBCDIC which would make the dump
>> files
>> not portable across platforms.

And it provides no way to turn this off? Ewww.
What are you supposed to do if you are redirecting binary data (which
dumpfiles are, really)

>> It would simplify things greatly for us if
>> svnadmin dump/load had an optional final parameter added to specify the
>> dump file name. The code could then just open the dump file itself and
>> read/write to it. This would allow us to maintain control of the
>> environment and the character encodings and avoid the EBCDIC conversion.
>> Of course the current behavior would remain the default.
>>
>> We are prepared to work on and submit this patch, but want to know if it
>> is likely to be accepted before we bother as it seems like the sort of
>> change some people might feel strongly about. If it is something that is
>> likely to be accepted, then we will develop and submit it independent of
>> the EBCDIC stuff we are doing which should keep it cleaner and make it
>> easier to review.
>
> I have no objection to the proposed feature. Suggest that you post a
> detailed spec first -- give the option's name(s), and its exact
> behavior. That way people know exactly what they're evaluating.

Karl seems to have assumed above that you are planning:

svnadmin load --someoptionname DUMPFILE REPOSITORY
svnadmin dump --someoptionname DUMPFILE REPOSITORY

instead of:

svnadmin load REPOSITORY DUMPFILE
svnadmin dump REPOSITORY DUMPFILE

I think I like the --option better too.

Likewise, no objections to the feature, if OS/400 really doesn't supply any
way to say "my stdout/stdin is binary, not textual".

Max.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 9 23:44:56 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.