On Wed, 8 Sep 2004, Tobias Ringström wrote:
> Peter N. Lundblad wrote:
>
> >On Sun, 5 Sep 2004 bliss@tigris.org wrote:
> >
> >
> >>+ if (fstat (0, &st) == -1)
> >>+ open ("/dev/null", O_RDONLY);
> >>
> >>
> >Errors here should be rare, but to be sure, shouldn't you bail out on
> >errors?
> >
> >
> I didn't consider it critical if that code failed, but since you're
> asking for it I've added it in r10855. I don't think we need to backport
> that part to 1.1, though.
>
OK. This is somewhat hypothetical, but... Say you're running in a chroot'd
environment where /dev/null doesn't exist, so the open fails. Then you
would have the same corruptions as before... OK, you've fixed this, just
wanted to say why I was so nasty...
:-)/P
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 9 20:27:28 2004