[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10841 - trunk/subversion/libsvn_wc

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-09-08 20:45:22 CEST

On Wed, 2004-09-08 at 10:46, kfogel@collab.net wrote:
> I wonder if that log message wouldn't be better as a comment in the
> code, right before the dir_status check?

Possibly. We don't have a similar comment in a later null check, and
I'm comfortable with the idea that someone cleaning up the code (perhaps
changing the definition of the statii field so that there is always an
entry) would have to do an svn blame and check some log messages to
figure out why the null check is there. But if someone wants to add the
comment, I won't object.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 8 20:45:51 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.