[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Checking paths are legal

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-09-02 21:28:13 CEST

On Thu, 2 Sep 2004, Jon Foster wrote:

> Currently, if a Windows user checks out a directory called "aux",
> they get an incomprehensible Subversion error. This is because
> "aux", "nul", etc and names containing ":" cannot be used as file or
> directory names on Windows. I'd like to make the error messages
> explicit about the problem.
This idea sounds good to me.

> Also, Subversion does not support files where the filename contains
> control characters (i.e. ASCII or [equivalently] Unicode values less
> than 32). Currently adding one of these files silently corrupts the
> working copy, and all further Subversion operations fail. I'd like
> to put in a sane error here, and not break the working copy. This
> isn't a problem on Windows, which doesn't support such files anyway,
> but can be a problem on Linux.
One more thing that it would be nice to check is that filenames are valid
UTF-8 when files enter the repository. I recently added code that checks
UTF-8 validity when we convert from UTF-8 to the system's encoding (even
if that happens to also be UTF-8). This prevents us from giving invalid
UTF-8 to the file system. But when we just receive UTF-8 (for example from
a client), we don't check it AFAIK. I would put this validation in the FS
code, since valid UTF-8 is a requirement in those APIs.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 2 21:14:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.