[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10788 - in trunk/subversion: include libsvn_subr

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-09-01 16:44:29 CEST

Mark Benedetto King wrote:

>On Wed, Sep 01, 2004 at 02:15:16AM +0200, Branko ??ibej wrote:
>>I think there is a better way to do this, that could avoid using global
>>data and locks: add the xlate cache to the svn_client_context_t struct,
>>and document that this structure is thread-specific. Most public
>>functions need to grow a thread-specific context parameter anyway,
>>although that will have to wait for 2.0. But I think it should be
>>possible to use the cache from the context in most places where we do
>>charset conversions now, by adding a set of conversion functions that
>>take a context parameter.
>Why stop there? Why not just put an xlate callback in the client context?
Hum. That would definitely avoid the need to add new public xlate
functions. The problem is, though, that there are quite a few of those,
so it's not just one xlate callback but yet another vtable. I do think
this approach is worth considering, tbough.

(The words "C++" and "abstract classes" and "context objects" also keep
popping up in my mind every time I think about these things, *sigh*)

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 1 16:45:00 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.