[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] svncopy utility script with svn:externals

From: Ian Brockbank <Ian.Brockbank_at_wolfsonmicro.com>
Date: 2004-08-30 18:26:56 CEST

Hi John, Karl,

Okay, here are the updated scripts, along with a README.

John wrote:

> Thinking it over, I will go ahead and document the few nits I had
> with the code, which you are free to ignore:

Thanks!

> 1) In the comments preceeding each sub() definition, you have
> embedded tab characters, so the formatting doesn't line up correctly;

Oops! I thought I'd got myself set up to always insert spaces (that's
how I usually work). Obviously something slipped past.

> 2) The use of prototypes is problematic, but you are not
> writing OO code
> nor using pass-by-reference, so it isn't that big a deal;

Not sure what this all means. I prefer having prototypes to tell me
when I've added (or removed) an argument and forgotten to update the
caller(s).

> 3) The presence of test code in the main script (lines 145-163) is not
> optimal, but I don't know enough about the reasons behind it
> to give you
> a better suggestion;

Fair enough. Now I've got those functions working, I don't really need
it, so I've taken it out.

> 4) The POD needs some work, specifically the Synopsis wraps
> poorly (Perl
> adds spaces at the beginning of the line) and the options to -r don't
> format at all (try this instead):

Better now? I've checked it with both pod2text and pod2html.

Ian Brockbank
Senior Applications Software Engineer
e: ian.brockbank@wolfsonmicro.com / apps@wolfsonmicro.com
scd: ian@scottishdance.net
t: +44 131 272 7145
f: +44 131 272 7001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Aug 30 18:27:19 2004

This is an archived mail posted to the Subversion Dev mailing list.