Re: path.c:113: svn_path_join: Assertion `is_canonical (base, blen)' failed.

On Thu, Aug 26, 2004 at 01:52:47AM -0700, Ben Reser wrote:
> If everyone agrees with that I'll nominate r10731 for backport to 1.1.x
> and fix this fully on trunk. Otherwise, I'll revert r10731 and fix it
> on trunk and whatever the final fix is will be nominated to 1.1.x.
>
> Thoughts?

Uhh yeah I object to revert r10731 at all. It is possible to pass
'foo//bar' directly into svn_path_dirname() and that will still provide
a non-canonical result. Our canonical rules do not specify that this is
a non-canonical path, therefor svn_path_dirname() would be violating its
API contract without r10731. Therefore r10731 must be kept no matter
what we decide to do about svn_path_dirname() with respect to URIs.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org