[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svnlook: no more reporting extra newline in log message

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-08-18 14:56:02 CEST

Kristis Makris <mkgnu@gmx.net> writes:

> There seems to be an extra newline reported be svnlook info. This causes
> integration hooks to assume an extra newline is part of the log message,
> while this is not the case. I'm assuming the attached patch fixes this,
> but did not test.
>
> Would removing the extra newline be the right thing to do ?

No. The right thing to do would be the integration hooks to
actually pay attention to the 0 printed on line three, note that the
log message has 0 bytes, read zero bytes, and call it a day.

Alternatively, you can have your integration hooks *always* remove the
last \n from the log message, because svnlook *always* adds it (for
readability).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 18 15:45:25 2004

This is an archived mail posted to the Subversion Dev mailing list.