Re: issue #2006: severe new bug, help requested

kfogel@collab.net writes:

> Philip Martin <philip@codematters.co.uk> writes:
>> Index: subversion/mod_dav_svn/log.c
>> ===================================================================
>> --- subversion/mod_dav_svn/log.c (revision 10664)
>> +++ subversion/mod_dav_svn/log.c (working copy)
>> @@ -177,7 +177,7 @@
>>
>> case 'M':
>> SVN_ERR( dav_svn__send_xml(lrb->bb, lrb->output,
>> - "<S:modified-path>%s",
>> + "<S:modified-path>%s"
>> "</S:modified-path>" DEBUG_CR,
>> apr_xml_quote_string(pool, path, 0)) );
>> break;
>
> Holy cow.
>
> Uh, thank you, Philip.

If we were to use something like:

Index: subversion/mod_dav_svn/dav_svn.h
===================================================================
--- subversion/mod_dav_svn/dav_svn.h (revision 10664)
+++ subversion/mod_dav_svn/dav_svn.h (working copy)
@@ -493,7 +493,8 @@
 /* Output XML data to OUTPUT using BB. Use FMT as format string for the.
    output. */
 svn_error_t * dav_svn__send_xml(apr_bucket_brigade *bb, ap_filter_t *output,
- const char *fmt, ...);
+ const char *fmt, ...)
+ __attribute__((format(printf,3,4)));
 
then gcc would produce a warning:

/home/pm/sw/subversion/svn/subversion/mod_dav_svn/log.c: In function `log_receiver':
/home/pm/sw/subversion/svn/subversion/mod_dav_svn/log.c:179: warning: too many arguments for format

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org