[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Re: 1.1rc1 performance regression in 'svn status' (and also 1.1rc2)

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-08-16 22:45:56 CEST

On Sun, 15 Aug 2004, Greg Hudson wrote:

> On Sun, 2004-08-15 at 16:41, Peter N. Lundblad wrote:
> > I don't see a way to improve the performance via caching in pools. If we
> > want to fix this, I think we need to add init functions and be able to
> > detect if they were called. If this is problematic for 1.1 ( to which I
> > might agree), then we won't fix this until 1.2. This will hurt TSVN users
> > I think and that's bad because that's an important application on Windows.
> Let's introduce an optional initializer, but let's make it very limited
> and specific. "void svn_utf_initialize(void);". We acknowledge that
> it's a short-term hack. It can become a no-op in 1.x and can disappear
> in 2.0.
Here is this hack in the form of a patch that could have some review. If
someone is actually using the svn libs in a multi-threaded environment,
please test. I'm running the testsuite right now, and it seems to work.

I kept the original caching in the pool to not hurt performance even more
if svn_utf_initialize wasn't called. An alternative would be to drop it
and tell people to use this new API if they feel svn is too slow. Maybe
this cleanup could wait until we have the real solution in place.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Aug 16 22:32:49 2004

This is an archived mail posted to the Subversion Dev mailing list.