Re: svn commit: r10652 - trunk/subversion/clients/cmdline

> > - return svn_stream_printf (lb->out, pool,
> > - _("No commit for revision 0.%s"),
> > - APR_EOL_STR);
> > + return svn_cmdline_printf (pool,
> > + _("No commit for revision 0.%s"),
> > + APR_EOL_STR);
>
> You shouldn't use APR_EOL_STR when writing through the C standard library,
> which svn_cmdline_* do, since that will take care of LF -> local EOL
> sequence.

Ok, I understand what you say there, but the old code used the C library
too. So why did we not see this problem before then? I didn't change the
line, other than not to translate to locale.

> > - /* Convert log message from UTF8/LF to native locale and
> eol-style. */
> > + /* Convert log message from LF to native eol-style. */
> > svn_string_t *logmsg = svn_string_create (msg, pool);
> > - SVN_ERR (svn_subst_detranslate_string (&logmsg, logmsg, TRUE,
> pool));
> > - msg_stdout = logmsg->data;
> > + SVN_ERR (svn_subst_detranslate_string (&logmsg, logmsg, FALSE,
> pool));
> > + msg = logmsg->data;
>
> Since we are always on ASSCI-based systems, LF will be == '\n', so I think
> this is wrong for the same reason as above.

And I have the same question as above :-)

Really, I don't understand, since I did not change that part. The old code
opened a stream for stdout instead of using printf. That's all.

bye,

Erik.

-- 
NEU: WLAN-Router für 0,- EUR* - auch für DSL-Wechsler!
GMX DSL = supergünstig & kabellos http://www.gmx.net/de/go/dsl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org