[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Support for readonly flag - PROPOSED PATCH

From: John Peacock <jpeacock_at_rowman.com>
Date: 2004-08-13 20:18:11 CEST

Sergey Korotkov wrote:

> Any chance to get response on this?

I'll give you a response, but it might not be the one you are looking
for. ;)

1) Read the section "Patch submission guidelines" in HACKING;
specifically you didn't include a log entry documenting what you
changed, and you attached a zipped patch file (which makes it more
difficult to review).

2) Your patch file is a truly horrific combination of line endings (the
header of each diff has CR/LF, but the body has LF only).

3) Read also the section of HACKING which deals with code formatting;
you have tabs all over the place in your new code.

4) Enabling/disabling features based on #ifdef's is not popular among
the core developers (I know, because I proposed a patch which did just
that ;).

5) You need to be more patient; 1.1.0rc2 just came out and I would think
that most of the core developers are busy with testing that, and aren't
going to spend much time looking at new features.



John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 13 20:18:09 2004

This is an archived mail posted to the Subversion Dev mailing list.