Re: svn commit: r10521 - trunk/subversion/libsvn_subr

brane@tigris.org writes:

> Author: brane
> Date: Sat Aug 7 03:20:16 2004
> New Revision: 10521
>
> --- trunk/subversion/libsvn_subr/validate.c (original)
> +++ trunk/subversion/libsvn_subr/validate.c Sat Aug 7 03:20:16 2004
> @@ -70,7 +70,7 @@
> /* See comment in svn_mime_type_validate() above. */
> const apr_size_t len = strcspn (mime_type, "; ");
> return ((strncmp (mime_type, "text/", 5) != 0)
> - && (strncmp (mime_type, "image/x-xbitmap", len) != 0)
> - && (strncmp (mime_type, "image/x-xpixmap", len) != 0)
> + && (len != 15 || strncmp (mime_type, "image/x-xbitmap", len) != 0)
> + && (len != 15 || strncmp (mime_type, "image/x-xpixmap", len) != 0)

That 15 looks prone to error, particularly if/when more types get
added. How about something like

#define LEN_STRNCMP(s) (len != sizeof(s) - 1 \
                        || strncmp (mime_type, s, sizeof(s) - 1) != 0)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org