Re: [PATCH] BDB verbose errors
From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-08-07 21:27:44 CEST
On Sat, 2004-08-07 at 14:54, Max Bowsher wrote:
I'd go with #2 for now. It's the best of several bad solutions.
(BDB's documentation promises not to copy the error prefix, but to
Your log message and patch were word-wrapped. If you can't convince
The patch looks functionally correct but contains several style issues:
+ child_errors = bfd->bdb_errcall_pending_errors;
Don't use mixed declarations and code; it's not valid C89.
+ base_fs_data_t *bfd = (base_fs_data_t*) pfx_baton;
Put space before asterix.
+ if (bfd->bdb_errcall_pending_errors)
Indent by two spaces, not four. Put space before open paren.
+ if (bfd->user_errcall_handler)
Put space before open paren. Use NULL instead of 0 for pointer
+ bfd->env->set_errpfx (bfd->env, (char*)bfd);
Put space before asterix and after close paren of cast. (Moot after you
---------------------------------------------------------------------
|
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.