[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: Unnecessary path encoding in svnserve

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-08-07 07:18:54 CEST

(Sorry for the two-day latency on responding; work has been busy and I
wanted to think about this one carefully.)

On Wed, 2004-08-04 at 17:33, Peter N. Lundblad wrote:
> I've attached a patch that does this. This can be a security hole if not
> done correctly, so would someone please review it. I couldn't juse
> svn_path_is_backpath_present because it only checks for / as segment
> separator, which isn't enough on Windows ofcourse.

Hm. Would it be better to use svn_path_internal_style() to convert any
local separators (there shouldn't be any, but of course we can't trust
the client to honor that) and then use svn_path_is_backpath_present on
the result?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 7 07:19:15 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.