[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN Property 'character-set' or 'encoding' or something like

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-08-06 15:46:05 CEST

Kalle Olavi Niemitalo wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>
>>Yes, and in the meantime I withdrew my objection, and there is now
>>code in the 1.1 release candidate that takes this into account.
>>
>>
>
>Sorry, I haven't been paying attention. It's r10126, isn't it?
>The code seems wrong to me; it'll treat e.g. "image/x" as text.
>
>
What? Oh, bother...

Index: validate.c
===================================================================
--- validate.c (revision 10504)
+++ validate.c (working copy)
@@ -70,7 +70,7 @@
   /* See comment in svn_mime_type_validate() above. */
   const apr_size_t len = strcspn (mime_type, "; ");
   return ((strncmp (mime_type, "text/", 5) != 0)
- && (strncmp (mime_type, "image/x-xbitmap", len) != 0)
- && (strncmp (mime_type, "image/x-xpixmap", len) != 0)
+ && (len != 15 || strncmp (mime_type, "image/x-xbitmap", 15) != 0)
+ && (len != 15 || strncmp (mime_type, "image/x-xpixmap", 15) != 0)
           );
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 6 15:46:57 2004

This is an archived mail posted to the Subversion Dev mailing list.