[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Fwd: mod_dav_svn over-escapes index tag?]

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-07-28 23:56:58 CEST

On Wed, 28 Jul 2004, Hiroharu Tamaru wrote:

> Hi, I got onto dev list as well,
>
> At Tue, 27 Jul 2004 17:22:56 -0700, Ben Reser <ben@reser.org> wrote:
> > On Wed, Jul 28, 2004 at 12:21:20AM +0200, Peter N. Lundblad wrote:
> > > On Mon, 26 Jul 2004, Ben Collins-Sussman wrote:
> > >
> > > > I run subversion 1.0.6 on mod_dav_svn/apache2/FreeBSD-stable.
> > > >
> > > > I needed the following patch to correctly view the headings
> > > > (or whatever you would call it) of directory listings when
> > > > viewing the repository with a web browser (Mozilla).
> > > >
> > > > It patches where the index tag such as
> > > >
> > > > <index rev="nn" path="/trunk/XXXX">
> > > >
> > > > is generated for an xml response. The strings that are
> > > > failing are multibyte utf8 japanese characters that are in
> > > > place of XXXXX above. It gets escaped and shows up on
> > > > screen as-is, in %xx%xx%xx format.
> > > >
> > > Yes. A path is not an URL. I think it's a bug. Will apply the patch that
> > > removes URI-escaping if no one objects. If we want an URL, we need to add
> > > an href attribute.
> >
> > Wasn't the change he's removing added to fix another bug?
>
> Yes, that was exactly what I was afraid of.
> It was introduced in revision 6070, but to me the log message is not
> clear enough as to decide on it. So, I'd like some XML experts have
> it verified.
>
Are you sure? AFAICT, what was introduced in 6070 was the XML escaping,
which should stay. URI-escaping has been there from the beginning (r2297).
I think URI escaping should have been replaced with XML escaping in 6070.

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 28 23:45:05 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.