[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: PATCH: $Header$ keyword support (now with proper log message)

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-07-27 00:36:44 CEST

kfogel@collab.net wrote:
> Tobias Ringström <tobias@ringstrom.mine.nu> writes:
>>>Index: subversion/include/svn_subst.h
>>>- --- subversion/include/svn_subst.h (revision 10373)
>>>+++ subversion/include/svn_subst.h (working copy)
>>>@@ -83,6 +83,7 @@
>>> const svn_string_t *author;
>>> const svn_string_t *url;
>>> const svn_string_t *id;
>>>+ const svn_string_t *header;
>>>} svn_subst_keywords_t;
>>Incompatible changes to the API such as this one cannot be applied
>>before the next major version (2.x). If you want this change to be
>>acceptable for 1.x, you must create a new type, svn_subst_keywords2_t
>>and also make new versions of the public functions using the type,
>>e.g. you need to create svn_subst_build_keywords2 that takes
>>svn_subst_keywords2_t arguments, etc. The old functions should then be
>>marked as deprecated. I'm afraid that this will complicate the patch a
>>lot. :-(
> Why is adding a member to the end of a structure incompatible? Maybe
> there are other incompatible things about the patch, but this
> particular change seems compatible to me.

It's a public structure definition, you can't change the size by adding
a new field because people might be depending on the size, declaring
them on the stack, etc.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 27 00:37:00 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.