[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Fwd: mod_dav_svn over-escapes index tag?]

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-07-26 22:13:02 CEST

-----Forwarded Message-----
From: Hiroharu Tamaru <tamaru@myn.rcast.u-tokyo.ac.jp>
To: users@subversion.tigris.org
Subject: mod_dav_svn over-escapes index tag?
Date: Tue, 27 Jul 2004 05:00:43 +0900


I run subversion 1.0.6 on mod_dav_svn/apache2/FreeBSD-stable.

I needed the following patch to correctly view the headings
(or whatever you would call it) of directory listings when
viewing the repository with a web browser (Mozilla).

It patches where the index tag such as

  <index rev="nn" path="/trunk/XXXX">

is generated for an xml response. The strings that are
failing are multibyte utf8 japanese characters that are in
place of XXXXX above. It gets escaped and shows up on
screen as-is, in %xx%xx%xx format.

Accroding to svnindex.xsl, the 'path' attribute for the
'index' tag is printed literally just like the 'name'
attribute for 'dir' or 'file' tag, and in contrast with the
'href' attribute. Thus, it seems to me that the escaping is
unnecessary, or rather, unwanted.
(The name attrib is not escaped, whereas href attribute is,
and those are showing up fine; lines 2078 to 2093.)

Could some expert verify this?

Thanks in advance.

--- subversion/mod_dav_svn/repos.c- Thu Apr 1 03:12:16 2004
+++ subversion/mod_dav_svn/repos.c Thu May 27 02:05:20 2004
@@ -2051,7 +2051,7 @@
         if (href)
           ap_fprintf(output, bb, " path=\"%s\"",
- ap_escape_uri(resource->pool, href),
+ href,
         ap_fputs(output, bb, ">\n");

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 26 22:14:14 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.