Re: SVN passes long file names including spaces the wrong way to an external diffing engine?

On Thu, Jul 22, 2004 at 09:36:34PM +0200, Ben Collins-Sussman wrote:
>
> Hi Auke...
>
> Well, I added quotes around the arguments at those two places in the
> code, rebuilt on win32, and guess what? 'svn diff --diff-cmd
> c:\path\to\diff.exe' suddenly *stopped* working on files with spaces in
> their name. And they were working just fine for me beforehand!
>
> If you look at the code, notice that we're *not* invoking the external
> diff process via a shell: the arguments are being directly passed to
> the subprocess programmatically. So when I forcibly add quotes around
> the args, the diff program is most likely looking for a file with
> literal double-quote marks in its name!

> So Mike Pilato and I think we're barking up the wrong tree here. Is it
> possible that you just happen to be using an external diff.exe which
> doesn't understand long filenames? Which diff.exe you using? Where did
> you get it from? And maybe we can give you our own diff.exe binaries to
> try instead?

I was using GNU diff version 2.8.7, available at [1], and we also tried
another diff, from an old MSK Toolkit but that didn't work either.
Hence, we'd be very interested to hear which diff you're using and it
would be great if you could send it (if that's allowed, license wise,
obviously).

At this moment, the developers we have testing SVN are stuck (since
their updates and merges continue to bail out) so it would be great if
your diff would actually work.

Auke

 1. http://gnuwin32.sourceforge.net/packages/diffutils.htm

-- 
Auke Jilderda, Philips Research (Eindhoven, the Netherlands)
e-mail: auke.jilderda@philips.com, phone: +31 40 2764870 (or ext. 44791)
http://pww.innersource.philips.com, http://pww.opensource.philips.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org