[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

BDB vs FSFS API weirdness

From: Arkadiusz Miskiewicz <arekm_at_pld-linux.org>
Date: 2004-07-24 15:28:36 CEST

Hi,

I noticed that mailer.py uses svn.fs.open_berkeley() that will not work with
FSFS (if BDB+FSFS is compiled).

svn.fs.open(self.fs_ptr, db_path, 'fsfs', pool) won't work here because types
for open vs open_berkeley are different: _p_svn_fs_t, expected _p_p_svn_fs_t

W hile looking into it I noticed:
svn_error_t *
svn_fs_open_berkeley (svn_fs_t *fs, const char *path)
{
  fs_library_vtable_t *vtable;
  SVN_ERR (get_library_vtable (&vtable, DEFAULT_FS_TYPE, fs->pool));
  return vtable->open (fs, path, fs->pool);
}

Since now DEFAULT_FS_TYPE is compile time option this will work differently
depending on these options.

The name of funcion suggest that it opens berkeley DB only but it will open
FSFS if compiled without BDB, too.

IMO it should open BDB always and don't depend on compile options.

-- 
Arkadiusz Mi¶kiewicz     CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 24 15:28:56 2004

This is an archived mail posted to the Subversion Dev mailing list.