[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10380 - in trunk: . build

From: Ben Reser <ben_at_reser.org>
Date: 2004-07-22 19:40:41 CEST

On Thu, Jul 22, 2004 at 03:49:13PM +0200, Branko ??ibej wrote:
> I strongly object. This means I can no longer edit these files with a
> Windows editor that doesn't understand LF line endings. I understand
> you're making these changes to make it easier to generate a ZIP distro
> for Windows, but the shebang argument doesn't hold because you don't
> acutally have to use it (you can always say, e.g., "sh dist.sh" to avoid
> the problems). Even if the shell scripts are expected to be Unix-only,
> the Python and Perl scripts definitely aren't.

Even if I use sh autogen.sh (incidentally dist.sh isn't at issue here and I
didn't change it, it's not run by itself and is running before the
export that makes CRLF files is run), this won't be fixed. autogen.sh
and other scripts call even more scripts and presume that the shebang
line will do the invocation. We could fix that but it still wouldn't
fix our problem.

The shell scripts have to be in LF, not just started with an explict
command because bash treats \r as a valid char and passes it onto the
command line. My only other option was to recode the files in the
dist.sh script to LF before generating the zip file. But that seems
really silly when there's no reason for these files to be in CRLF anyway
as far as I can see.

On top of that just a couple months ago you argued that we didn't need
to ship a CRLF zip file becuase any decent editor on Windows understands
LF line endings. So which is it? Can you deal with LF line endings or
can't you?


I didn't change any Perl scripts. The only things I changed were a
couple of shell scripts that wouldn't even run on Windows and
gen-make.py. I probably can change gen-make.py back to native and use
an explicit path to run it. If that fixes it I'll change that back.
But I don't see the point in changing the shell scripts that don't even
run on Windows back to native.

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 22 21:10:21 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.