[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

SVN passes long file names including spaces the wrong way to an external diffing engine?

From: <auke.jilderda_at_philips.com>
Date: 2004-07-22 13:22:08 CEST

I seem to have run into a minor bug in SVN which I would like to verify
with you guys before submitting it to the issue tracker:

Earlier, we ran into a problem [1] which seems to be caused by a severe
performance drop of the contextual diff engine on large files (around 8
MB) on a not so fast machine (1.7 GHz Pentium). In turn, this causes
SVN to drop the connection. Configuring SVN to use GNU diff and diff3
instead is supposed to provide a work-around (until the contextual diff
engine gets fixed) but makes us run into a slightly different problem.

GNU diff bails out with a not so descriptive error message which turns
out to already have been posted once before on this list [2]. I suspect
it is simply a matter of not properly passing on long file names under
Windows -- manually running the diff like 'diff \dev\some file \dev\some
other file' fails with the same message while running 'diff "\dev\some
file" "\dev\some other file"' works fine. I consider this to be a bug
because the file system allows spaces in file names and, with that, SVN
should be able to cope with them.

Digged shortly in the code and I suspect that inserting quotes on line
1670 and 1671 of subversion/libsvn_subr/io.c should help a lot.
However, since I can't get the thing to build properly on Windows, I
cannot try it and send a patch.


PS: It would be greatly appreciated if somebody with a working build on
     Windows could send me his binaries when fixing this. (hint! ;-))

  1. http://subversion.tigris.org/servlets/ReadMsg?list=users&msgNo=14257
  2. http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=29761

Auke Jilderda, Philips Research, Eindhoven, the Netherlands
e-mail: auke.jilderda@philips.com, phone: +31 40 2764870
http://pww.innersource.philips.com, http://pww.opensource.philips.com
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 22 13:23:36 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.