[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Log receiver and NULL changed-path hashes

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2004-07-20 21:17:35 CEST

Greg Hudson <ghudson@MIT.EDU> writes:

> The docstring for svn_log_message_receiver_t says:
>
> * If @a changed_paths is non-@c NULL, then it contains as keys every path
> * committed in @a revision; the values are (@c svn_log_changed_path_t *)
> * structures (see above).
>
> I want to file a 2.0 issue changing this so that if there are no
> changed paths, the receiver gets an empty hash table rather than a
> NULL one. There's nothing so special about a revision with zero
> changes that the log handler should need to special-case it.
>
> Object now or don't.

+1. It's worth the cost of an empty hash table in memory to simplify
the lives of structure readers.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 20 21:18:30 2004

This is an archived mail posted to the Subversion Dev mailing list.