Re: svn log causes XML parse error (internal error)

Peter N. Lundblad wrote:
> On Mon, 19 Jul 2004, Simon Odou wrote:
>
>
>>For the same project, the svn behavior is different with "file://" and
>>"http://". Commits with particular log message can be rejected with "http" but
>>accepted with "file". Then the command "svn log" might fail.
>>
>>$ svn co http://localhost/test && cd test
>>Checked out revision 0.
>>$ touch a && svn add a
>>A a
>>$ echo "a" >> a && svn ci -m `echo -ne "\0x1"`
>>svn: Commit failed (details follow):
>>svn: applying log message
>>to /test/!svn/wbl/0f562004-95df-0310-837a-e85ba3689386/0: 400 Bad Request
>>(http://localhost)
>>
>
> [...]
>
> This is because there is no way to put control characters in XML (well,
> one could introduce ones own escaping mechanism, see last weeks discussion
> about control chars in file names). I think we should filter out
> characters that are not valid XML characters. OK, we could base64-encode

Control characters in *filenames* aren't problem for WebDAV, because
WebDAV is talking about URIs (which never ever contain control
characters, using %hh escaping).

If control characters appear anywhere else in WebDAV XML
request/response bodies (properties?), that simply should be fixed.

> them, but does the DAV elements allow that? Also, are those potential

It allows anything you want that is compatible to what the spec says,
but you can't expect interoperability with other clients/servers then.

> compability problems worht it just for the fun of being able to screw up
> someone else's terminal? :-) Couldn't we just check all svn: properties
> and be done with it?
>
> (Probably not for some reason I don't think of...)

What's the use case for having control characters in properties?

Julian

-- 
<green/>bytes GmbH -- http://www.greenbytes.de -- tel:+492512807760
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org