Re: README.txt in created repository always says '"db" contains a Berkeley DB environment'

Oliver Rutherfurd <orutherfurd@gmail.com> writes:
> I just created an fsfs repository, and README.txt in the repository dir says:
>
> The directory "db" contains a Berkeley DB environment.
> You may need to tweak the values in "db/DB_CONFIG" to match the
> requirements of your site.
>
> I poked around in the source, and it looks like this is hard-coded in
> "create_repos_structure" in repos.c, regardless of the type of
> repository created. I mentioned this on #svn and maxb suggested I
> drop a note here.

I tried to conditionalize this in

   subversion/libsvn_repos/repos.c:create_repos_structure()

but it wasn't clear how to discover the repository back end.
'svn_repos_t' doesn't contain any field for this, though it does
contain an 'svn_fs_t'.

When I look at svn_fs_t, there's a 'config' field that might or might
not have the answer. If one looks up the key SVN_FS_CONFIG_FS_TYPE in
config, will the value be either SVN_FS_TYPE_FSFS or SVN_FS_TYPE_BDB?

SVN_FS_CONFIG_FS_TYPE's behavior is not documented for anything except
svn_fs_create(). I'm not sure if it can be tested when opening an
existing filesystem.

Maybe we should add an API to svn_fs.h:

   /* Return a string indicating the type of @a fs. For example,
      SVN_FS_TYPE_FSFS or SVN_FS_TYPE_BDB. The returned string is
      constant, not allocated in any pool. */
   svn_fs_type(svn_fs_t *fs);

Greg or Josh, any advice?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 14 19:20:30 2004