[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10242 - trunk/subversion/libsvn_repos

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-07-12 03:47:28 CEST

Greg Hudson wrote:
> On Sun, 2004-07-11 at 18:07, rooneg@tigris.org wrote:
>>- if (src_rev_from_map = apr_hash_get (pb->rev_map, &nb->copyfrom_rev,
>>- sizeof(nb->copyfrom_rev)))
>>+ if ((src_rev_from_map = apr_hash_get (pb->rev_map, &nb->copyfrom_rev,
>>+ sizeof(nb->copyfrom_rev))))
> Normally we would write this as an assignment statement followed by "if
> (src_rev_from_map)", as recommended by the Gnu coding style (which we
> admittedly only follow loosely).

I don't have any particular objection to your suggestion, other than the
fact that the 'if ((foo = blah()))' style is already scattered
throughout this particular file (see svn_repos_parse_dumpstream2,
make_node_baton, make_revision_baton, and probably other places). If
someone wants to go through and 'correct' all of those, then fine, more
power to them, but for now I just did the 'smallest thing that would
stop the warning'.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 12 03:47:37 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.