[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'last N changes' mode for svn log

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-07-10 16:32:01 CEST

Ben Reser wrote:
> On Mon, Jul 05, 2004 at 10:17:27PM -0600, Michael W Thelen wrote:
>
>>If the repos HEAD revision is 100, I would expect HEAD:HEAD-10 to return
>>the log messages for the range 100 through 90, regardless of how many
>>changes were undergone by the target(s) in that range. I see "HEAD-10"
>>as specifying a revision number independent of any targets.
>
>
> I agree. I wanted to implement this range stuff for a different
> purpose. Namely making scripting of ranged operations possible, without
> a human figuring out what HEAD is. If you start using this syntax for
> limiting the number of log entries returned it'll be very difficult to
> provide this other feature. Plus I find this usage non-intuitive.

At this point, I agree that the +/- on start and end points of ranges is
useful, but I don't think I'm going to implement it as part of this
round of changes. Nothing I'm working on seems like it would preclude
adding it in the future, but I'm more interested in the 'last N changes'
type functionality, so that's where I'll be focusing my energy.

>>That's not to say that "give me the last 10 log messages" isn't a very
>>common desire. I'm just not sure HEAD:HEAD-10 is the syntax for it.
>>Something more like HEAD:HEAD-10C (last ten changes before HEAD), or a
>>different command-line option entirely, like --limit 10, would make more
>>sense to me.
>
>
> +1 on --limit.
>
> -0 on anything else.
>
> Also probably the most common place people want to use this is to get
> the last so many logs just by typing svn log in their wc. Typing out:
>
> svn log -r HEAD:HEAD-10
>
> seems to be far less intuitive, suddenly I'm having to think about that
> I want HEAD, and not just being happy with whatever the defaults are.
> This seems much nicer (assumming --limit can be shorted to -l)
>
> svn log -l 10
>

This seems reasonable to me. Once I find the free time I'll rework my
changes to use a --limit/-l type interface and repost the patch.

Thanks for all the comments everyone,

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 10 16:32:19 2004

This is an archived mail posted to the Subversion Dev mailing list.