[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1947 Submission #4 svn_path_uri_decode may copy garbage and overrun buffer when given partial % escape

From: Ben Reser <ben_at_reser.org>
Date: 2004-07-10 12:14:57 CEST

On Thu, Jul 08, 2004 at 11:45:50AM +0200, Klaus Rennecke wrote:
> Branko ??ibej wrote:
>
> >[...] macros that evaluate the argument more than once are evil.
>
>
> Ow. That na´ve macro of mine was asking for more trouble than there was
> before.
>
> >[...]
> >Just fix the patch and I'll apply it. :-)
>
>
> Yessir! :-)
>
> /Klaus
>
> [[[
> Check that the two characters following the % escape are valid hex digits.
> This serves to check for premature end of input as well.
>
> Fixes Issue #1947 svn_path_uri_decode may copy garbage and overrun buffer
> when given partial % escape.
>
> * subversion/libsvn_subr/path.c
> (svn_path_uri_decode): Check syntax of % escape.
>
> * subversion/tests/libsvn_subr/path-test.c
> (test_uri_decode): New test function.
> (test_funcs): Added test_uri_decode.
> ]]]
>

Committed in r10199 and r10211 (two commits because I missed this email
and the test suite).

One other comment. Please make your patches relative to the trunk dir.
It just makes it so much easier to apply becuase I don't have to count
how many paths I need to tell patch to rip off...

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 10 12:15:09 2004

This is an archived mail posted to the Subversion Dev mailing list.