[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1947 Submission #3 svn_path_uri_decode may copy garbage and overrun buffer when given partial % escape

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-07-08 09:17:39 CEST

Klaus Rennecke wrote:

> I'm now directly comparing to ASCII values, so this should not be an
> issue anymore. Keeps things simple as well. :-)

Don't do that. Just use apr_isxdigit, otherwise we'd give a false sense
of supporting platforms with native encodings that aren't ASCII- based.
Besides, macros that evaluate the argument more than once are evil.

> Should I try to squeeze the new patches onto the issue tracker?

Just fix the patch and I'll apply it. :-)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 8 09:19:14 2004

This is an archived mail posted to the Subversion Dev mailing list.