Re: [PATCH] add version queries and version checks (issue 1861)

Greg Hudson wrote:
> On Tue, 2004-07-06 at 17:35, Branko Čibej wrote:
>
>>Mm, looks like we have a bit of a misunderstanding there. I thought you
>>were against putting version queries in the vtables, when you're
>>actually just objecting to exporting them from the libraries. Is that
>>correct? If so, I can definitely go along with that.
>
>
> Right. Adding them to the vtables is fine. Adding them to the module
> libraries without doing the vtable work is confusing and pointless;
> exporting them unnecessarily is also pointless.

OK. So shall I go ahead and add the private svn_pluginname__version()
functions, and also append them to the vtable? (I take it the nicest
place to add them is at the end.)

Also: can the public svn_ra_svn_version() function -- checked by
svnserve -- be used in the vtable for ra_svn?

I did consider adding some code for checking the versions of plugins to
lisvn_fs and libsvn_ra, but TBH I'm not confident to do that at this stage.

Edmund.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 7 07:09:34 2004