[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: herding 1.1 issues into the corral

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-07-06 23:49:11 CEST

kfogel@collab.net wrote:
> Ben Collins-Sussman <sussman@collab.net> writes:
>
>>### 1949 mod_authz_svn COPY bug: Is this a 1.1 showstopper or not?
>> Should we implement pseudo-O(N) copies, or just doc around it?
>
>
> Not a showstopper, IMHO. We've had the bug forever; we should doc
> around it for 1.1, not delay 1.1 when we don't even know the fix yet.

Of course we know the fix. mod_authz_svn reads the entire authz INI
file into memory for every request. All we need to do is

   1. write a function in mod_authz_svn.c which verifies whether a user
has read access to an entire tree. That's just a matter of looping over
all paths in the authz file which prefix-match the tree.

   2. invoke this function on the source path of any COPY request.

Pretty easy stuff. Personally, I think we should do it. COPY requests
(svn cp URL1 URL2) are relatively rare, and we can document the fact
that mod_authz_svn places a bit of a damper on O(1) copies.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 23:47:22 2004

This is an archived mail posted to the Subversion Dev mailing list.