[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add version queries and version checks (issue 1861)

From: Edmund Horner <chrysophylax_at_chrysophylax.cjb.net>
Date: 2004-07-06 15:19:12 CEST

Branko Čibej wrote:
> Edmund Horner wrote:
>
>> Greg Hudson wrote:
>>
>>> On Mon, 2004-07-05 at 02:01, Edmund Horner wrote:
>>>
>>>> However I have added svn_libname__version() functions for the plugin
>>>> libraries.
>>>
>>> Pointless and messy. Until such a time as the vtable work is done to
>>> make it possible to query an FS or RA module's version after
loading it,
>>> don't add any symbols like this.
>>>
>>> (There's no urgency to doing this work, since the RA/FS ABI version
will
>>> serve in the meantime.)
>>
>> Righty ho.
>>
>> I have removed the svn_libname__version() functions from svn_fs_base,
>> svn_fs_fs, svn_ra_local, svn_ra_dav.
>>
>> The function svn_ra_svn_version() function remains, since it is
>> checked by svnserve/main.c. Does that sound ok?
>
>
> Um. I said in my previous post that I disagree. I think these functions
> should go in, and so should the version check changes in the vtables.
> And there's no need to change the vtables first.
>
> -- Brane

Okay, I'm a little confused about what needs to be done. Does this mean
the second patch was (relatively) acceptable, even with the plugin
version functions not in the vtables?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 17:06:34 2004

This is an archived mail posted to the Subversion Dev mailing list.