[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_get_commit_log_t callback

From: Martin Hauner <hauner_at_web.de>
Date: 2004-07-06 11:23:17 CEST

kfogel@collab.net writes:

> Martin Hauner <hauner@web.de> writes:
> > is it safe for a subversion client programm to modify the
> > (not const) commit_items array passed to the callback (ie.
> > remove items from it)?
>
> That seems like a bad idea. The doc string is unclear on the effect
> of this; probably we should have made that argument 'const', and/or
> documented that the array is not to be modified.
>
> What exactly are you trying to do?

I'm trying to find a good way to handle a commit dialog. tortoisesvn for example uses
a dialog with a text field for the log message and a list of all the commitable files.
Each file has a checkmark which i can deselect to not commit it. This is nice because
I can call up a diff for the file from the list, write the log message for it or if I find it is
not interesting for this commit i simply deselect the file. As far as i can see from the
tsvn source, it doesn't use the callback for this.

I just wondered if something like this could be done directly from the callback by
modifying commit_items.

-- 
Martin, http://subcommander.tigris.org
_______________________________________________________
WEB.DE Video-Mail - Sagen Sie mehr mit bewegten Bildern
Informationen unter: http://freemail.web.de/?mc=021199
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 6 11:34:44 2004

This is an archived mail posted to the Subversion Dev mailing list.