[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10143 - in trunk/subversion: libsvn_subr tests/libsvn_subr

From: Klaus Rennecke <kre_at_tigris.org>
Date: 2004-07-05 17:47:02 CEST

Greg Hudson wrote:

>On Mon, 2004-07-05 at 11:30, Klaus Rennecke wrote:
>
>
>>+ else if (SVN_PATH_IS_PLATFORM_EMPTY(path, len))
>>+ return 0;
>>
>>
>
>This check should no longer be necessary with the new
>svn_path_canonicalize.
>
>

Well, only if all callers canonicalize before ending up here. I don't
have enough overview to judge this so I kept the behaviour identical.

>(Note that the function name should change with this check taken out;
>the "nonempty" doesn't apply. It didn't exactly apply before; "./foo"
>would be truncated to "", but "foo/./bar" would still only be truncated
>to "foo/.".)
>
>

Actually the first version of the patch *did* truncate foo/./bar to foo
but since that was a semantic change I undid it.

/Klaus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 5 17:48:49 2004

This is an archived mail posted to the Subversion Dev mailing list.