[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10132 - trunk/subversion/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-07-04 18:00:09 CEST

Greg Hudson wrote:

>This commit seems a little rough, and it seems like an odd enough design
>that perhaps it should have been hashed out on the dev list. (Perhaps
>it was, and I missed it.)
>
>On Sun, 2004-07-04 at 01:06, breser@tigris.org wrote:
>
>
>>+static apr_status_t wait_for_input_or_timeout(apr_file_t *f,
>>+ apr_interval_time_t timeout,
>>+ apr_pool_t *pool)
>>+{
>>
>>
>
>
>
>>+ srv = apr_poll(&pollset, 1, &n, 10);
>>
>>
>
>You appear to be ignoring the timeout parameter.
>
>
>
>>+ status = wait_for_input_or_timeout(fp,10,pool);
>>
>>
>
>Spaces after commas?
>
>
>
>>+ if (status != APR_SUCCESS && status != APR_ENOTIMPL)
>>+ continue;
>>
>>
>
>Shouldn't you be testing specifically for a timeout result? What's so
>special about APR_ENOTIMPL?
>
>The timeout should really be unnecessary. Unless I'm missing something,
>apr_poll() should terminate with EINTR if a signal occurs. (On Unix,
>anyway. I don't know how this all works under Windows.)
>
>
It probably doesn't. The apr_poll function is notoriously tricky.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 4 18:03:39 2004

This is an archived mail posted to the Subversion Dev mailing list.