[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH) compile warnings from msgfmt

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-07-03 18:41:38 CEST

On Sun, 27 Jun 2004, Greg Hudson wrote:

> > About the long names: they are verbose, but consistent with what
> > autoconf uses (HAVE_functionname). I added IF_ for as a prefix when
> > the condition is true and IF_NOT_ when it is false.
>
> Uh, sure, you're consistent with the symbol names autoconf uses for C
> code, but I don't see why this matters. But if you look at other
> real-life examples of people doing Makefile conditionalization using
> this approach, they almost always use short symbol names for
> conciseness. (When they're not using automake, that is.)
>
> You aren't using AC_DEFINE on these symbols, so they won't affect the
> C code namespace, only the Makefile namespace. I suggest using
> @NO_CHARSET@.
>
Thanks for the suggestion. I used GETTEXT_CODESET and NO_GETTEXT_CODESET.
Had to split the sed line anyway...

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 3 18:31:07 2004

This is an archived mail posted to the Subversion Dev mailing list.