[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10129 - in trunk: build/generator subversion/bindings/swig subversion/bindings/swig/java/org/tigris/subversion subversion/bindings/swig/java/org/tigris/subversion/swig

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-07-03 13:53:16 CEST

rey4@tigris.org wrote:

>Modified: trunk/build/generator/gen_win.py
>Url: http://svn.collab.net/viewcvs/svn/trunk/build/generator/gen_win.py?view=diff&rev=10129&p1=trunk/build/generator/gen_win.py&r1=10128&p2=trunk/build/generator/gen_win.py&r2=10129
>==============================================================================
>--- trunk/build/generator/gen_win.py (original)
>+++ trunk/build/generator/gen_win.py Fri Jul 2 23:46:23 2004
>@@ -379,6 +379,13 @@
> string.join(map(lambda x: "-I%s" % self.quote(x),
> includes)),
> self.quote(csrc))
>+ elif target.lang == 'java':
>+ outdir = "%s\\subversion\\bindings\\swig\\java\\org\\tigris\\subversion\\swig" % rootpath
>+ cbuild = "swig %s -%s -package org.tigris.subversion.swig -outdir %s %s -o %s $(InputPath)" % \
>+ (self.swig_options, target.lang, outdir,
>+ string.join(map(lambda x: "-I%s" % self.quote(x),
>+ includes)),
>+ self.quote(cout))
>
>
This is the third customized version of the SWIG command line in
gen_win.py. Now the funny thing here is that the Unix build _also_
generates custom command lines for each target. There's not that much
differente between Unix and Windows, as far as SWIG is concerned, is
there? So couldn't we sort of extract this per-language SWIG
configuration info into a single config file used by both generators,
please?

I'm really becoming rather tired of seeing this kind of logic in the
code -- _twice_ -- when it properly belongs in config files. The
generators are beginning to look like a perpetual hack.

>+#ifdef SWIGJAVA
>+/* Ignore these function pointer members because swig's string
>+ representations of their types approach the maximum path
>+ length on windows, causing swig to crash when it outputs
>+ java wrapper classes for them. */
>+%ignore svn_ra_plugin_t::do_diff;
>+%ignore svn_ra_plugin_t::do_switch;
>+%ignore svn_ra_plugin_t::do_status;
>+%ignore svn_ra_plugin_t::do_update;
>+%ignore svn_ra_plugin_t::get_log;
>+#endif
>
>
and

>+#ifdef SWIGJAVA
>+/* Ignore these function pointer members because swig's string
>+ representations of their types approach the maximum path
>+ length on windows, causing swig to crash when it outputs
>+ java wrapper classes for them. */
>+%ignore svn_wc_diff_callbacks_t::file_added;
>+%ignore svn_wc_diff_callbacks_t::file_changed;
>+%ignore svn_wc_diff_callbacks_t::file_deleted;
>+#endif
>
>
So the comment about getting the bindings to build on Windows was
literal -- build, but not work. I wonder if it's all worth the trouble,
then?

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 3 13:54:20 2004

This is an archived mail posted to the Subversion Dev mailing list.