[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #692: Handle "svn log" with empty repos

From: <kfogel_at_collab.net>
Date: 2004-07-02 23:11:55 CEST

Michael W Thelen <thelenm@cs.utah.edu> writes:
> But speaking of elegance... both special case (a) and (b) seem to be
> made necessary by the fact that we default to HEAD:1 and BASE:1 instead
> of HEAD:0 and BASE:0 when the user passes no arguments to "svn log".
> While writing the patch, I thought it would have been much nicer if we
> could just pass HEAD:0 to ra_lib->get_log and have it "do the right
> thing". That is, produce an r0 log message when the start and end
> revisions requested are both 0, but don't tack an r0 log message on the
> end otherwise.

It's hard to imagine a circumstance under which the r0 logs could be
relevant to anyone, since no user created r0. And the behavior
proposed above is... Well, let's just say I had to read it three times
myself, and I was already thinking hard about the issue :-). Do you
really want to have to document that behavior for users?

(IOW, I'm punting on the question of interface compatibility, because
even if this were compatible, I don't think we'd want to do it.)

I think r1 is a good default for almost all cases. In the rare times
when it's not, we can notice the problem, and handle the special case.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 3 00:39:16 2004

This is an archived mail posted to the Subversion Dev mailing list.