[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10114 - in trunk: . subversion/include subversion/libsvn_client subversion/libsvn_subr subversion/libsvn_wc subversion/tests/clients/cmdline

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-07-02 01:46:30 CEST

Josh Pieper wrote:

>Branko ??ibej wrote:
>
>
>>jpieper@tigris.org wrote:
>>
>>
>>
>>>+ /* On Win32, CreateFile failswith an "Access Denied" error
>>>+ code, rather than "File Already Exists", if the colliding
>>>+ name belongs to a directory. */
>>>
>>>
>>>
>>>
>>Isn't this Win32-specific comment inside an '#ifdef HAVE_SYMLINK'
>>somewhat strange?
>>
>>
>
>Well, I believe it was you who said we should test for features, not
>platforms. There might be some platform that supports symlinks, but
>does return the access denied error...
>
>
Hm. O.K.

We're going to have to solve this platform-specific mess in a more
consistent way soon. We're piling hacks upon hacks. Yah. Seems to me we
need a portability guideline document (or section in HACKING). There are
some things APR simply isn't intended to handle.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 2 01:49:59 2004

This is an archived mail posted to the Subversion Dev mailing list.