Re: svn commit: r10100 - trunk/subversion/libsvn_subr

Branko Čibej <brane@xbc.nu> writes:
> Ben Reser wrote:
>
> >On this basis, I'm -1 on this commit.
>
> I agree. I should've closed that issue before it got in the
> queue. Sorry about the omission.
> By the way, your arguments apply to to X bitmap types, too.

Can't really argue with Ben's points; and a -1 after the commit is
just as legit as a -1 before the commit. I've reverted the change.

> I agree on this, too. It means that the mime-type validation must
> first search for the end of the content type proper -- that would be
> either ';', ' ', or the end of the string. And the function that
> determines "text" mime types should do the same kind of narrowing.

Agreed; and for the record I'm not planning to do this myself (other
things, like security review, on my plate), so if someone wants to,
please go for it.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 30 21:07:50 2004