kfogel@collab.net wrote:
>Ben Collins-Sussman <sussman@collab.net> writes:
>
>
>>>Make svnadmin load less verbose by default and add a --verbose flag.
>>>
>>>
>>Did we forget to run 'make check'? This breaks all the
>>svnadmin_tests.py tests.
>>
>>
Oh crap, I must have. I thought I always did, but obviously I failed
this time. My apologies!
>For now, I'll fix it by adding '--verbose' to the invocation in the
>test framework, so we don't lose any more developer time on this.
>
>
You say in your next email that this didn't work which I find very
surprising because it works perfectly here. I just changed
load_args = ' load "' + dst_path + '"'
to
load_args = ' load -v "' + dst_path + '"'
in main.py. All tests pass now with my patch included.
>However, in the long term, I feel it's wrong that we changed the
>default output format of 'svnadmin load' in a 1.x release. The output
>formats are part of the API. If anyone is tempted to argue with that,
>I will simply point to the current situation as proof :-).
>
>
That was why I posted the patch several days before committing it.
>I don't think we need to revert r10091. We just need to tweak it so
>that the default is verbosity; -q produces quiet operation; we file a
>2.0 issue to change the default; and of course we can revert the
>band-aid change I'm about to commit to the test suite.
>
>
There is already a -q option to make it quiet, but it makes it print
nothing.
I wanted a less verbose load because I've been running cvs2svn and
svnadmin load a lot lately and the load scrolls the output so fast that
I can't even see what revision it is at. It's not more important than
that, so I'll drop the patch.
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 29 09:50:56 2004