[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_sleep_for_timestamps makes things unresponsive

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-06-28 08:13:59 CEST

Folker Schamel wrote:

> Branko ÄŒibej wrote:
>
> > C.A.T.Magic wrote:
> >
> > > I have no (FAT) filesystem available with only a 2 second resolution,
> > > but i could think of a situation like this
> > > ! imaginary example !:
> > >
> > > svn update
> > > #=> creates file1 with current time 00:00:00.10
> > > #=> FAT rounds this to 00:00:02
> > > #=> svn stores that time as 'last modified' in its entries file.
> > > #=> user modifies a character in the file no size change)
> > > # at 00:00:01.30 -- FAT rounds this to 00:00:02 again.
> > > svn commit
> > > #=> does nothing - file time hasn't changed, size hasn't changed
> > > #=> user thinks everything is committed and deletes his WC,
> > > or a release version is built without the required fix etc.
> >
> > This is a very contrived example. First, it's very unlikely that a user
> > would do something like that in under 2 seconds.
>
> Then why is there a need for a sleep at all?

You're quoting out of context. My objection to this particular example
was that it's used to demonatrate a case of "data loss", but this is not
data loss.

The sleep is necessary in for correctness, so that a user (or a script!)
won't be surprised by nothing happening. If FAT has a 2-second time
granulation, and we only sleep for a maximum of 1 second, then that's
obviously a bug in our code.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 28 08:14:48 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.