Re: svn commit: r10064 - trunk/subversion/libsvn_fs_base

Branko Čibej wrote:

> sussman@tigris.org wrote:
>
>> Author: sussman
>> Date: Wed Jun 23 17:35:02 2004
>> New Revision: 10064
>>
>> Modified:
>> trunk/subversion/libsvn_fs_base/fs.c
>> Log:
>> Fix issue #1818: make 'svnadmin hotcopy' copy in increments of BDB
>> pagesize.
>>
>>
> Thie breaks the build with BDB 4.0, which doesn't have a
> DB->get_pagesize function.

Oh yes, and are you absolutely sure you want to copy in page size
chunks? Remember, BDB wants a _multiple_ of the page size. Copying files
in 4K chunks is not very efficient. I'd suggest a multiple of the page
size that's closest to our delta window size, that would make the memory
usage consistent with the rest of Subversion.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 25 14:52:24 2004