Re: Unix-only code (was Re: svn commit: r10060 - trunk/subversion/libsvn_fs)

Greg Hudson wrote:

> On Thu, 2004-06-24 at 07:30, John Peacock wrote:
>
>>Why not add a stanza to configure to probe for the feature? This is always
>>the best method...
>
>
> That seems a little silly; as far as I know, configure only runs on
> systems which have this functionality.

I was actually proposing a more narrowly tailored #if test, that just so
happens to work correctly where configure runs. I fully expect to have
to create a static configuration for VMS based on what configure would
normally provide.

My main objection was to hiding #include's with WIN32, since that is too
broad a brush to help anyone who isn't Unix OR Win32

>
> I also don't know what a configure test for the sgid bit would look
> like. (Remember that the host system isn't necessarily the same as the
> target system.)

Are there really that many people cross-compiling (if that is what you
are talking about)? I believe the only possible test (since this isn't
a normally supported feature test) is to compile a stub program which
attempts to perform the actions that your patch performs and then sees
if it worked.

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org