[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r10060 - trunk/subversion/libsvn_fs

From: John Peacock <jpeacock_at_rowman.com>
Date: 2004-06-24 13:30:54 CEST

Greg Hudson wrote:
> On Wed, 2004-06-23 at 15:33, kfogel@collab.net wrote:
>
>>ghudson@tigris.org writes:
>>
>>>+#ifndef WIN32
>>>+/* Required for the sgid code in svn_fs_create */
>>>+#include <sys/stat.h>
>>>+#include <sys/types.h>
>>>+#include <unistd.h>
>>>+#endif
>>
>>Is this our normal way of saying "if Unix-like operating system"?
>
>
> Yes, it is. See lots of other cases in libsvn_subr/io.c.
>

Doesn't make it the right method, though. At some point, I plan on spending
some significant time getting Subversion working under VMS (I know, can't be
helped) and the more of these "If it's not WIN32 it _must_ be Unix" bodges I
have to dodge, the more difficult it is going to be. Why not add a stanza to
configure to probe for the feature? This is always the best method...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 24 13:31:42 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.