[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Checking format strings in .po files

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-06-23 23:24:47 CEST

> [Moving this discussion to the dev list]

Which probably did not show up yet; the list address is dev@ (not devel@)
:-)
 
> On Wed, 23 Jun 2004, Erik Huelsmann wrote:
>
> > > On Wed, 23 Jun 2004, Greg Stein wrote:
> > >
> > > > For translations... heck yah. That's an even lower part than partial
> > > > commit access to the raw code.
> > > >
> > > Hmmm... Remember that a translation is part of the code. A bad
> translation
> > > can introduce crashes due to formatting strings. But only for that
> > > language. That was why I wanted to add --check-format to the msgfmt
> > > command line some week ago.
> >
> > I think we can't do that in the Makefile, but I could include this check
> in
> > my cronjob (which I will commit when it proves alright).
> >
> But we could add the -c option in the Makefile if we add
> Last-Translator: Subversion Developers <dev@subversion.tigris.org>
> to every .po file. (In fact my msgfmt only checks that the header is
> there, so we could possibly leave it empty, but that's ugly.)
 
I think this is a good convention. If you do that to all po files, would you
also document it in TRANSLATING please?

> I'd like to have the check in the regular build so we make sure we don't
> release with a translation which crashes svn.

Well, if I add the check to the cronjob, that would have almost the same
effect; I don't expect a commit rate to the translations as high as that on
the rest of our code. (Is that incorrect?)

> If no one objects, I can do this in all .po files and change the
> Makefile.in. Anyone knows if -c is available in other msgfmt programs that
> we support?

That's why I thought we can't do it to the main build:
http://www.netsys.com/cgi-bin/solaris9?msgfmt(1) seems to indicate Solaris 9
does not support -c.

bye,

Erik.

-- 
"Sie haben neue Mails!" - Die GMX Toolbar informiert Sie beim Surfen!
Jetzt aktivieren unter http://www.gmx.net/info
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 23 23:27:05 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.