On Sun, 20 Jun 2004, Shlomi Fish wrote:
> Hi all!
>
> Attached is a proposed patch to Issue #1901:
>
Nice to see you're working on this.
> A possible problem is that: (which I wrote in the Issue Page):
>
> <<<
> Well, the patch I sent above corrects the problem, but I'm not sure if in the
> right way. It does so, by filtering out double slashes from URLs inputted to
> the svn_client_copy() and svn_client_move() functions. So, the bug still
> exists in the lower levels, but it isn't encountered this way.
>
> We should decide whether we can deal with double slashes in URLs (or in paths)
> when being inputted at every stage, or that the routines can be expected to
> fail if given such input.
> >>>
>
I don't think this is the correct solution. I think you are fixing
symptoms, not causes. Actually, we need to be careful not to treat URLs as
normalized paths.
> Fixes Issue #1901 ( Crash in copy command with URL with double slashes ).
>
> * include/svn_path.h
> Added the declaration of svn_path_url_remove_multiple_slashes().
>
I think this is a too specific function name. We may want to do other URI
normalization as well, such as canonicalizing %3f to %3F and such. When
we've decided on this, it should be done consistently in some layer.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 20 22:44:16 2004