[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9725 - in trunk: . build build/generator packages/rpm/fedora-1 packages/rpm/mandrake-9.0 packages/rpm/mandrake-9.1 packages/rpm/mandrake-9.2 packages/rpm/redhat-7.x packages/rpm/redhat-8+ packages/rpm/wbel-3 subversion/include subversion/libsvn_fs subversion/libsvn_ra subversion/libsvn_subr

From: Greg Stein <gstein_at_lyra.org>
Date: 2004-06-20 18:44:58 CEST

On Sat, May 15, 2004 at 02:50:55AM -0500, brane@tigris.org wrote:
>...
> * subversion/include/svn_version.h (SVN_VER_PATCH): Replaces SVN_VER_MICRO.
> (SVN_VER_MICRO): Deprecate. Replace all uses with SVN_VER_PATCH.
> (SVN_VER_LIBRARY): Deprecate. Replace all uses with SVN_VER_MAJOR.
> (svn_version_t::patch): Renamed from 'micro', all uses updated.
>...
> +++ trunk/subversion/include/svn_version.h Sat May 15 02:50:46 2004
>...
> @@ -143,7 +143,7 @@
> {
> int major; /**< Major version number */
> int minor; /**< Minor version number */
> - int micro; /**< Patch number */
> + int patch; /**< Patch number */

Eek. That is a source-level incompatibility. This isn't allowed for a 1.x
release. 1.0 libraries need to be able to compile against the 1.x headers.
This will break that.

The #define changes look good, but this part, and the source changes
related to it, need to be reverted however.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 20 18:49:27 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.