On Fri, Jun 18, 2004 at 11:16:09AM -0500, Ben Collins-Sussman wrote:
> Arghh. We've actually received compliments from outsiders about how
> Subversion's code base is so clean, that we're "the only project they've
> ever seen where ./configure && make produces no warnings at all."
> According to Fitz, I believe Apple Computer(?) once compiled Subversion
> source in a presentation for exactly that reason. :-)
>
> I'd hate to blow that reputation.
>
> Is 'make' building the exact same set of things for swig/perl as it does
> for swig/python? That is, just the glue libraries, and nothing else?
> If it's also building the "meat" of the bindings, perhaps we can push
> that into a separate rule, the same way we do with 'make swig-py'?
>
> I'm just grasping at straws here.
Actually no. I'm building the entire thing. But those warnings come
form the glue libraries.
For what it's worth the Python bindings produce at least one warning for
me in the glue libraries:
/bin/sh /home/breser/wc/svn-trunk/libtool --silent --mode=compile gcc
-DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE
-D_GNU_SOURCE -DSWIGPYTHON -g -g -Wall -Wmissing-prototypes
-Wstrict-prototypes -Wmissing-declarations -pthread -DNEON_ZLIB
-DNEON_SSL -DSVN_DEBUG -DAP_DEBUG -Wpointer-arith -Wwrite-strings
-Wshadow -std=c89 -I/home/breser/wc/svn-trunk/subversion/bindings/swig
-I/home/breser/wc/svn-trunk/subversion/include -I/usr/lib/swig1.3
-DSVN_SWIG_VERSION=103019 -I/usr/include/apache2 -I/usr/include/apache2
-I/usr/include/python2.3
-I/home/breser/wc/svn-trunk/subversion/bindings/swig/python/libsvn_swig_py
-I./subversion/include -I. -I/usr/include/neon -I/usr/include/apache2
-I/usr/include/apache2 -o
subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.lo -c
/home/breser/wc/svn-trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
In file included from /usr/include/python2.3/Python.h:8,
from
/home/breser/wc/svn-trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:20:
/usr/include/python2.3/pyconfig.h:856:1: warning: "_XOPEN_SOURCE"
redefined
<command line>:7:1: warning: this is the location of the previous
definition
And even more if I actually do:
make swig-py
In the perl bindings case, things are the opposite, the glue libraries
are the warning noisy ones, the native stuff is very quiet.
The only thing I could do would be if we're using gcc just turn off the
warnings for that particular message, but I'm not sure I like that idea.
Plus it does nothing for people on other platforms.
At any rate per our agreement on IRC, we no longer build bindings stuff
by default.
--
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 18 18:42:33 2004